Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenStack Metrics scaler #1692

Merged
merged 12 commits into from
Mar 29, 2021

Conversation

Rodolfodc
Copy link
Contributor

@Rodolfodc Rodolfodc commented Mar 22, 2021

Provide a description of what has been changed

Add new scaler, Openstack Metrics Scaler

Signed-off-by: rodolfodc r.costa@sidi.org.br

Checklist

Related to #1382

@Rodolfodc Rodolfodc changed the title Add openstack aodh metrics scaler Add openstack metrics scaler Mar 23, 2021
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
@Rodolfodc Rodolfodc force-pushed the add_openstack_aodh_metrics_scaler branch from 96b04a0 to 97d58af Compare March 24, 2021 21:15
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
@zroubalik zroubalik changed the title Add openstack metrics scaler Add OpenStack Metrics scaler Mar 26, 2021
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you been thinking about adding e2e test for this scaler?

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/openstack_metrics_scaler.go Outdated Show resolved Hide resolved
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
@Rodolfodc
Copy link
Contributor Author

Rodolfodc commented Mar 26, 2021

Have you been thinking about adding e2e test for this scaler?

Hi @zroubalik, yes! I'm working within @pdominguite, I have already done some manually and I'm gonna start working on keda e2e tests for this scaler soon.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 1f48e66 into kedacore:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants