Handle password value correctly; add tests. #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor Dolby <tdolby@uk.ibm.com>
tdolby-at-uk-ibm-com
requested review from
ahmelsayed and
zroubalik
as code owners
|
Seemed a bit too trivial a change for me to update the Changelog, but I can do so if it would help. |
Yeah it's trivial, but it is fixing a bug, so I prefer to have it in the Changelog, thanks! |
Signed-off-by: Trevor Dolby <tdolby@uk.ibm.com>
|
Changelog updated |
Signed-off-by: Trevor Dolby <tdolby@uk.ibm.com>
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
Signed-off-by: Trevor Dolby <tdolby@uk.ibm.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trevor Dolby tdolby@uk.ibm.com
Use passwords from secrets correctly.
Checklist
Fixes #1938