Provide Solace Queue Scaler #1945

dennis-brinley · 2021-07-09T20:01:20Z

Signed-off-by: Dennis Brinley dennis.brinley@solace.com
Includes solace_scaler Unit tests, end-to-end tests, and mod to handler
** I'm waiting for sign-off for the documentation. Will commit early next week.

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Checklist

Commits are signed with Developer Certificate of Origin (DCO - learn more)
Tests have been added
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (Provide documentation for Solace PubSub+ Event Broker scaler keda-docs#486) (if applicable)
Changelog has been updated

Fixes #

Signed-off-by: Dennis Brinley <dennis.brinley@solace.com> Includes solace_scaler Unit tests, end-to-end tests, and mod to handler By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

…nd comments Applies to solace_scaler tests Signed-off-by: Dennis Brinley <dennis.brinley@solace.com> By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

zroubalik · 2021-07-12T09:11:30Z

Thanks, there are a couple of linting problems and some failing test, could you please fix that?

Signed-off-by: Dennis Brinley <dennis.brinley@solace.com> By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Code cleanup, removed comments, unused meta fields Signed-off-by: Dennis Brinley <dennis.brinley@solace.com> By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

dennis-brinley · 2021-07-12T18:36:35Z

Corrected

pkg/scalers/solace_scaler.go

tomkerkhove · 2021-07-13T06:32:27Z

Thank you for your contribution @dennis-brinley! I'll take a look at the docs asap!

scale-handler.go: - Changed scaler ID to "solace-event-queue" solace_scaler.go: - changed metadata identifer prefixes from "msg" to "message" where applicable" - added multiplier to messageSpoolUsageTarget (1024^2) so metadata values are expressed in MBytes - updated some var names (camel case not followed after re-name) solace_scaler_test.go - Mods to reflect change in scaler code solace-helpers.ts - Mod to test procedure to allow message size to be specified for test publisher (test message spool usage) - Mod to trigger/scaler name in scaledobject config solace.tests.ts - added tests to scale up/down based on message spool usage (kedacore#5 and kedacore#6) (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Dennis Brinley <dennis.brinley@solace.com>

zroubalik

Looking good, +100 for thorough test coverage.

Minor nit in metadata from env variables naming.

pkg/scalers/solace_scaler.go

Updated var names for config metadata passed from env Signed-off-by: Dennis Brinley <dennis.brinley@solace.com> (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

ahmelsayed · 2021-07-14T19:50:07Z

A small merge conflict in CHANGELOG.md

Signed-off-by: Dennis Brinley <dennis.brinley@solace.com> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>

dennis-brinley requested review from ahmelsayed and zroubalik as code owners July 9, 2021 20:01

dennis-brinley and others added 4 commits July 12, 2021 11:23

Merge branch 'kedacore:main' into solace-scaler

20f73a6

zroubalik reviewed Jul 12, 2021

View reviewed changes

pkg/scalers/solace_scaler.go Show resolved Hide resolved

tomkerkhove changed the title ~~Commit changes for solace-queue scaler~~ Provide Solace Queue Scaler Jul 13, 2021

tomkerkhove added this to the v2.4.0 milestone Jul 13, 2021

zroubalik requested changes Jul 14, 2021

View reviewed changes

pkg/scalers/solace_scaler.go Outdated Show resolved Hide resolved

dennis-brinley requested a review from zroubalik July 14, 2021 14:10

ahmelsayed approved these changes Jul 14, 2021

View reviewed changes

zroubalik approved these changes Jul 14, 2021

View reviewed changes

Merge branch 'main' into solace-scaler

ada9946

zroubalik merged commit cb3e971 into kedacore:main Jul 14, 2021

dennis-brinley deleted the solace-scaler branch July 15, 2021 12:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide Solace Queue Scaler #1945

Provide Solace Queue Scaler #1945

dennis-brinley commented Jul 9, 2021 •

edited by zroubalik

Loading

zroubalik commented Jul 12, 2021

dennis-brinley commented Jul 12, 2021

tomkerkhove commented Jul 13, 2021

zroubalik left a comment

ahmelsayed commented Jul 14, 2021

Provide Solace Queue Scaler #1945

Provide Solace Queue Scaler #1945

Conversation

dennis-brinley commented Jul 9, 2021 • edited by zroubalik Loading

Checklist

zroubalik commented Jul 12, 2021

dennis-brinley commented Jul 12, 2021

tomkerkhove commented Jul 13, 2021

zroubalik left a comment

Choose a reason for hiding this comment

ahmelsayed commented Jul 14, 2021

dennis-brinley commented Jul 9, 2021 •

edited by zroubalik

Loading