Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TriggerAuthentication/Vault: add support for vault namespace #2085

Merged
merged 2 commits into from
Sep 10, 2021
Merged

TriggerAuthentication/Vault: add support for vault namespace #2085

merged 2 commits into from
Sep 10, 2021

Conversation

chapurlatn
Copy link
Contributor

@chapurlatn chapurlatn commented Sep 1, 2021 •
edited
Loading

Signed-off-by: Nicolas Chapurlat nc@coorganix.com

Related to this issue: #2084
Related to this discussion: #2080

Changes

  • Add an optional "namespace" in Keda TriggerAuthentication spec: spec.hashiCorpVault.namespace
  • Optionally configure the Vault namespace in the Vault client
  • REMOVED FROM THIS PR: Make sure the VAULT_NAMESPACE env var never takes precedence (Vault client default behaviour)

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added no test yet in vault section (I performed a local integration test I could provide)
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified) => not applicable
  • A PR is opened to update the documentation on (repo) (if applicable) => Done: TriggerAuthentication/Vault: add support for vault namespace keda-docs#522
  • Changelog has been updated

Relates to #2084

@chapurlatn chapurlatn mentioned this pull request Sep 1, 2021
Merged
1 task
@JorTurFer
Copy link
Member

JorTurFer commented Sep 1, 2021 •
edited
Loading

Is this related with the issue TriggerAuthentication/Vault: add support for vault namespace?

@chapurlatn chapurlatn closed this Sep 2, 2021
@chapurlatn
Copy link
Contributor Author

Is this related with the issue TriggerAuthentication/Vault: add support for vault namespace?

Yes @JorTurFer, I added a ref in the main comment.

@chapurlatn chapurlatn reopened this Sep 2, 2021
@chapurlatn
TriggerAuthentication/Vault: add support for vault namespace
97bb7f7 
Signed-off-by: Nicolas Chapurlat <nc@coorganix.com>
@zroubalik
Copy link
Member

Thanks for the contribution!

@zroubalik zroubalik merged commit a223a0e into kedacore:main Sep 10, 2021
@zroubalik zroubalik mentioned this pull request Oct 4, 2021
Closed
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@chapurlatn @zroubalik @nilayasiktoprak
TriggerAuthentication/Vault: add support for vault namespace (kedacor…
80d139e 
…e#2085)

Signed-off-by: Nicolas Chapurlat <nc@coorganix.com>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees

@zroubalik zroubalik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapurlatn @JorTurFer @zroubalik @ahmelsayed