Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to get connection data from Trigger Authorization in MSSQL Scaler #2112

Merged
merged 4 commits into from
Oct 4, 2021
Merged

Add support to get connection data from Trigger Authorization in MSSQL Scaler #2112

merged 4 commits into from
Oct 4, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Sep 21, 2021 •
edited
Loading

Signed-off-by: jorturfer jorge_turrado@hotmail.es

Adds support to getthe connection data from Trigger Authorization in MSSQL Scaler

Checklist

Fixes #2108

@JorTurFer
Adds support to set the connection data from Trigger Authorization
068c354 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title Adds support to getthe connection data from Trigger Authorization in MSSQL Scaler Add support to getthe connection data from Trigger Authorization in MSSQL Scaler Sep 21, 2021
@JorTurFer
Update CHANGELOG
b0dffc4 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title Add support to getthe connection data from Trigger Authorization in MSSQL Scaler Add support to get the connection data from Trigger Authorization in MSSQL Scaler Sep 21, 2021
@JorTurFer JorTurFer changed the title Add support to get the connection data from Trigger Authorization in MSSQL Scaler Add support to get connection data from Trigger Authorization in MSSQL Scaler Sep 21, 2021
@JorTurFer
Update CHANGELOG
43bf0a6 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer mentioned this pull request Sep 21, 2021
Merged
1 task
zroubalik
zroubalik approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 0242b98 into kedacore:main Oct 4, 2021
@JorTurFer JorTurFer deleted the mssql_trigger branch October 4, 2021 09:01
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@zroubalik @nilayasiktoprak
Add support to get connection data from Trigger Authorization in MSSQ…
9caa338 
…L Scaler (kedacore#2112)

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide support for configuring authentication through TriggerAuthentication for MS SQL scaler
2 participants
@JorTurFer @zroubalik