Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Scaler: fix wrong calculation of retry backoff duration #2416

Merged
merged 3 commits into from
Jan 4, 2022
Merged

External Scaler: fix wrong calculation of retry backoff duration #2416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6011c8a
fix: wrong calculation of retry backoff duraion
yusank Dec 27, 2021
1925453
Merge branch 'kedacore:main' into main
yusank Jan 4, 2022
1bbb9b3
docs(CHANGELOG): update improvements section
yusank Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
- PostgreSQL Scaler: Assign PostgreSQL `userName` to correct attribute ([#2432](https://github.com/kedacore/keda/pull/2432))
- Kafka Scaler: concurrently query brokers for consumer and producer offsets ([#2405](https://github.com/kedacore/keda/pull/2405))
- Delete the cache entry when a ScaledObject is deleted ([#2408](https://github.com/kedacore/keda/pull/2408))
- External Scaler: fix wrong calculation of retry backoff duration ([#2416](https://github.com/kedacore/keda/pull/2416))

### Breaking Changes

Expand Down
2 changes: 1 addition & 1 deletion pkg/scalers/external_scaler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ func (s *externalPushScaler) Run(ctx context.Context, active chan<- bool) {
// timer, to release background resources.
retryBackoff := func() *time.Timer {
tmr := time.NewTimer(retryDuration)
retryDuration *= time.Second * 2
retryDuration *= 2
if retryDuration > time.Minute*1 {
retryDuration = time.Minute * 1
}
Expand Down