Allow using simple queue names in aws sqs scaler #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaferraro
force-pushed
the
sqs-queueurl
branch
3 times, most recently
from
3bec0ca
to
0f269f3
Compare
|
Hi @nicolaferraro , |
|
I see you've checked " A PR is opened to update the documentation on (repo) (if applicable)" but I don't see a PR on https://github.com/kedacore/keda-docs/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc. Would you mind updating the docs for 2.6 please? |
1 task
|
Yes, I thought it wasn't required, but I've opened this: kedacore/keda-docs#628. Sure, I've tested it manually and using the new integration I've created in Camel K. |
Signed-off-by: nicolaferraro <ni.ferraro@gmail.com>
nicolaferraro
force-pushed
the
sqs-queueurl
branch
from
0f269f3
to
181a079
Compare
JorTurFer
previously approved these changes
Jan 17, 2022
|
Added concern on doc PR given we are re-using the |
markrzasa
pushed a commit
to markrzasa/keda
that referenced
this pull request
Jan 27, 2022
Signed-off-by: nicolaferraro <ni.ferraro@gmail.com> Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
markrzasa
pushed a commit
to markrzasa/keda
that referenced
this pull request
Jan 27, 2022
Signed-off-by: nicolaferraro <ni.ferraro@gmail.com> Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS SQS autoscaler does not really need a full queueURL, it also works with simple queue names, but there was some code that tried to parse the URL to get the queue name for building a metric ID.
The example in the doc already uses a simple name.
Checklist
Fixes #