Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a demand checker for Azure Pipelines #2707

Closed
wants to merge 6 commits into from
Closed

Added a demand checker for Azure Pipelines #2707

wants to merge 6 commits into from

Conversation

Eldarrin
Copy link
Contributor

@Eldarrin Eldarrin commented Mar 2, 2022

Added a parameter to the metadata so that you can specify a parent template which must be the ADO agent name of the offline agent.

Job now compares the template name to determine if it is matched to a potential agent

Issues: If more than one agent can fulfil the job, multiple jobs can be instantiated as they decide independently that they are able to fulfil.

Docs: kedacore/keda-docs#685

Andy

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #2328

Signed-off-by: mortx <mortxbox@live.com>
Signed-off-by: mortx <mortxbox@live.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind addind some tests?

pkg/scalers/azure_pipelines_scaler.go Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@zroubalik
Copy link
Member

@Eldarrin please check you PR, seems like there is something broken and there are included changes from another PRs.

@Eldarrin
Copy link
Contributor Author

Seems like my fork is corrupted with a previous merge. May be best if I kill the fork, You close the PR. I'll open a new PR with a clean fork and reference this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants