Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logic for prometheus scaler X-Scope-OrgID header #2763

Merged
merged 3 commits into from
Mar 16, 2022
Merged

feat: add logic for prometheus scaler X-Scope-OrgID header #2763

merged 3 commits into from
Mar 16, 2022

Conversation

xoanmm
Copy link
Contributor

@xoanmm xoanmm commented Mar 15, 2022 •
edited by zroubalik
Loading

Signed-off-by: Xoán Mallón xoanmallon@gmail.com

Provide a description of what has been changed

Checklist

Fixes #2667

@xoanmm xoanmm requested a review from a team as a code owner March 15, 2022 20:30
@JorTurFer
Copy link
Member

JorTurFer commented Mar 15, 2022 •
edited by github-actions bot
Loading

/run-e2e prometheus*
Update: You can check the progres here

@xoanmm xoanmm mentioned this pull request Mar 15, 2022
Merged
1 task
zroubalik
zroubalik approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

xoanmm added 3 commits March 16, 2022 14:38
@xoanmm
feat: add logic for prometheus scaler X-Scope-OrgID header
2062bf0 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
docs: update CHANGELOG
14c6909 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: solve golangci errors
7e4a9ed 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm xoanmm force-pushed the feature/add-cortex-org-query-prometheus-scaler branch from aee976b to 7e4a9ed Compare March 16, 2022 13:38
@zroubalik
Copy link
Member

zroubalik commented Mar 16, 2022 •
edited by github-actions bot
Loading

/run-e2e prometheus*
Update: You can check the progres here

@zroubalik zroubalik merged commit 092196a into kedacore:main Mar 16, 2022
RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022
@xoanmm @RamCohen
feat: add logic for prometheus scaler X-Scope-OrgID header (kedacore#…
5ce50bf 
…2763)

Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@aberenshtein
Copy link

when will this be released?

@JorTurFer
Copy link
Member

Next release will be on May @aberenshtein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for X-Scope-OrgID header in Prometheus scaler
4 participants
@xoanmm @JorTurFer @zroubalik @aberenshtein