Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added support for vault kv-v1 (#2645) #2772

Closed
wants to merge 3 commits into from
Closed

fix: Added support for vault kv-v1 (#2645) #2772

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78284e1
fix: Added support for vault kv-v1 (#2645)
chaunceyt Mar 11, 2022
1ae7e97
fix: Updated changelog
chaunceyt Mar 19, 2022
b7e37c2
fix: Updated changelog
chaunceyt Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/scaling/resolver/scale_resolvers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,12 @@ func resolveVaultSecret(logger logr.Logger, data map[string]interface{}, key str
logger.Error(fmt.Errorf("key '%s' not found", key), "Error trying to get key from Vault secret")
return ""
}
} else if v1Data, ok := data[key]; ok {
if s, ok := v1Data.(string); ok {
return s
}
}

logger.Error(fmt.Errorf("unable to convert Vault Data value"), "Error trying to convert Data secret vaule")
logger.Error(fmt.Errorf("unable to convert Vault Data value"), "Error trying to convert Data secret value")
return ""
}