Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus: check and properly inform user that threshold is not set #2794

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Prometheus: check and properly inform user that threshold is not set #2794

merged 1 commit into from
Mar 22, 2022

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubalik@gmail.com

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2793

@zroubalik
Check and properly inform user that threshold is not set
8106a9a 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik requested a review from a team as a code owner March 22, 2022 19:24
@zroubalik
Copy link
Member Author

zroubalik commented Mar 22, 2022 •
edited by github-actions bot
Loading

/run-e2e prometheus*
Update: You can check the progres here

JorTurFer
JorTurFer approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer JorTurFer merged commit e62a75d into kedacore:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus should print appropriate error if threshold is not specifed
2 participants
@zroubalik @JorTurFer