GCP Storage scaler: Add Prefix and Delimiter support #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
JorTurFer
reviewed
Oct 25, 2022
There was a problem hiding this comment.
Looking good! Could you solve DCO issues? All commits need to be signed.
Should we add an e2e test for this feature?
Also, I'd like to share that we have some issues with GCP account that we're solving with CNCF support, so atm we cannot trigger GCP e2e test, so before merging this PR I prefer to solve them and trigger GCP e2e test.
Of course, thanks for the contribution! ❤️
Signed-off-by: Ward Loos <ward@banked.com>
wrdls
force-pushed
the
add-prefix-to-gcp-storage
branch
from
d04e329
to
bfd56da
Compare
|
/run-e2e gcp* |
JorTurFer
approved these changes
Nov 3, 2022
|
Thanks @JorTurFer for the approval ❤️ |
|
Thanks to you for the improvement!! ❤️❤️❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ward Loos ward.loos@gmail.com
Provide a description of what has been changed
Checklist
Fixes #3756
Relates to #963