Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support unsafeSsl and enable ssl verification as default #4006

Merged
merged 3 commits into from
Dec 16, 2022
Merged

fix: Support unsafeSsl and enable ssl verification as default #4006

merged 3 commits into from
Dec 16, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Dec 12, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4005

@JorTurFer
fix: Support unsafeSsl and enable ssl verification as default
e2ca973 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner December 12, 2022 18:21
@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 12, 2022 •
edited by github-actions bot
Loading

/run-e2e redis*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

if you agree, I'd merge this ignoring the suggestions about the min TLS version, because I'd like to address all of the at once

@JorTurFer
Merge branch 'main' into fix-redis
7a44b8b 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 15, 2022 •
edited by github-actions bot
Loading

/run-e2e redis*
Update: You can check the progress here

@JorTurFer
Merge branch 'main' into fix-redis
cc14f54 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer JorTurFer enabled auto-merge (squash) December 16, 2022 09:55
@JorTurFer JorTurFer merged commit 6c49e26 into kedacore:main Dec 16, 2022
@JorTurFer JorTurFer deleted the fix-redis branch December 16, 2022 10:18
@JorTurFer JorTurFer mentioned this pull request Jan 17, 2023
Closed
1 task
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Jan 18, 2023
@JorTurFer
fix: Support unsafeSsl and enable ssl verification as default (kedaco…
3414fe5 
…re#4006)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app semgrep-app left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis Scalers: Support unsafeSsl and enable ssl verification as default
2 participants
@JorTurFer @zroubalik