Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor scale_handler.go #4131

Merged
merged 2 commits into from
Jan 17, 2023
Merged

chore: refactor scale_handler.go #4131

merged 2 commits into from
Jan 17, 2023

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubalik@gmail.com

Just shuffling a few methods and splliting the code to be more readable. No functional changes.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik requested a review from a team as a code owner January 17, 2023 16:40
@zroubalik
Copy link
Member Author

zroubalik commented Jan 17, 2023

/run-e2e
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only 1 suggested change inline

pkg/scaling/scalers_builder.go Outdated Show resolved Hide resolved
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik merged commit 22a5111 into kedacore:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants