Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate GetMetrics() and IsActive() to GetMetricsAndActivity() #4238

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Consolidate GetMetrics() and IsActive() to GetMetricsAndActivity() #4238

merged 5 commits into from
Feb 16, 2023

Conversation

troydn
Copy link
Contributor

@troydn troydn commented Feb 14, 2023

This PR consolidates GetMetrics() and IsActive() to GetMetricsAndActivity() for the remaining scalers (Azure Event Hub, Cron and External).

Checklist

Fixes #4015

@troydn
Event Hub: merge GetMetrics and IsActive
69a54cf 
Signed-off-by: Troy <troydenorme@hotmail.com>
@troydn
Cron: merge GetMetrics and IsActive
fddef2e 
Signed-off-by: Troy <troydenorme@hotmail.com>
@troydn
External: merge GetMetrics and IsActive
2c7d1bf 
Signed-off-by: Troy <troydenorme@hotmail.com>
@troydn
update changelog
1ad925c 
Signed-off-by: Troy <troydenorme@hotmail.com>
@troydn troydn requested a review from a team as a code owner February 14, 2023 20:16
@troydn
fix fmt
3e13a48 
Signed-off-by: Troy <troydenorme@hotmail.com>
@zroubalik
Copy link
Member

zroubalik commented Feb 15, 2023 •
edited by github-actions bot
Loading

/run-e2e cron*
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Feb 15, 2023 •
edited by github-actions bot
Loading

/run-e2e external*
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Feb 15, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

zroubalik
zroubalik approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for the contribution!

@zroubalik zroubalik merged commit 2042337 into kedacore:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate GetMetrics() and IsActive() to GetMetricsAndActivity()
2 participants
@troydn @zroubalik