fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) #4401

Eldarrin · 2023-03-22T16:41:14Z

Added a simple hotfix to grab different querystring excluding top when parent is required,

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #
#4387

Relates to #

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

JorTurFer · 2023-03-24T07:59:45Z

/run-e2e pipelines*
Update: You can check the progress here

tests/scalers/azure/azure_pipelines_adv/azure_pipelines_adv_test.go

…st.go Agreed Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com>

JorTurFer · 2023-03-24T09:43:15Z

/run-e2e pipelines*
Update: You can check the progress here

Eldarrin · 2023-03-24T12:23:15Z

@JorTurFer I think running the new tests in parallel with the old tests upset ADO :)

JorTurFer · 2023-03-26T20:14:58Z

@JorTurFer I think running the new tests in parallel with the old tests upset ADO :)

Is it something we can mitigate? I mean, eventually both test will run in parallel

Eldarrin · 2023-03-26T20:25:49Z

I can mitigate it, does your copy of ADO support running parallel self hosted jobs? The basic ado account doesn’t

JorTurFer · 2023-03-26T20:29:16Z

I can mitigate it, does your copy of ADO support running parallel self hosted jobs? The basic ado account doesn’t

I think so:

Eldarrin · 2023-03-26T20:31:41Z

Ok, will do in the morning and update

JorTurFer · 2023-03-26T20:32:29Z

Ok, will do in the morning and update

Sure, no rush! I have just checked GH after a disconnecting weekend 😄

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

Eldarrin · 2023-03-27T09:01:09Z

Ok, so new patch should allow e2e to run in parallel, can't really test at home as only have a basic account for ADO.
You will need to add a new agent pool (can be empty), change the new pipeline to point to the new pool and put the poolname as the new .env variable added for AZURE_DEVOPS_DEMAND_POOL_NAME=

JorTurFer · 2023-03-27T17:55:44Z

I guess that we need to update also the pipeline definition to use the new agent, right?

JorTurFer · 2023-03-27T17:55:51Z

/run-e2e pipelines*
Update: You can check the progress here

JorTurFer

LGTM! Thanks for the awesome job (as always) ❤️
Should we add a note in docs to clarify that &top statement only applies without demands?

JorTurFer

Could you add a record in the changelog? I didn't notice it before

Eldarrin · 2023-03-27T21:43:35Z

Could you add a record in the changelog? I didn't notice it before

Will do in the morning :)

Done :)

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

Signed-off-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com>

JorTurFer · 2023-03-28T11:06:44Z

/run-e2e pipelines*
Update: You can check the progress here

kedacore#4387) (kedacore#4401) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io>

kedacore#4387) (kedacore#4401) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

…<Jorge_turrado@hotmail.es> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com> Co-authored-by: Eugene Lugovtsov <34510252+EugeneLugovtsov@users.noreply.github.com> fix(aws-sqs): Respect `scaleOnInFlight` value (#4358) fix odd number of arguments passed as key-value pairs for logging (#4369) fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) (#4401) fix: respect all required demands in azure pipeline scaler (#4405) fix: Allow to remove the finalizer even if the ScaledObject isn't valid (#4397) * Drop a transitive dependency on bou.ke/monkey (#4366) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix(aws-sqs): Respect `scaleOnInFlight` value (#4358) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * chore: update supported versions in the welcome message (#4360) Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix odd number of arguments passed as key-value pairs for logging (#4369) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) (#4401) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: respect all required demands in azure pipeline scaler (#4405) Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: Allow to remove the finalizer even if the ScaledObject isn't valid (#4397) Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * update changelog Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io> Co-authored-by: Eugene Lugovtsov <34510252+EugeneLugovtsov@users.noreply.github.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Andy Ward added 3 commits March 22, 2023 16:28

Fix and new e2e for (#4387)

665b4eb

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

Leave old tests

2f90b18

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

Full fix for (#4387)

d02c28c

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

Eldarrin requested a review from a team as a code owner March 22, 2023 16:41

Fix for issue (#4387)

7de1a86

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

JorTurFer changed the title ~~Fix for issue (#4387)~~ fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) Mar 24, 2023

JorTurFer approved these changes Mar 24, 2023

View reviewed changes

JorTurFer reviewed Mar 24, 2023

View reviewed changes

tests/scalers/azure/azure_pipelines_adv/azure_pipelines_adv_test.go Outdated Show resolved Hide resolved

Update tests/scalers/azure/azure_pipelines_adv/azure_pipelines_adv_te…

80eb0bf

…st.go Agreed Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com>

Updated e2e to allow parallelism

df03282

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

JorTurFer approved these changes Mar 27, 2023

View reviewed changes

JorTurFer requested changes Mar 27, 2023

View reviewed changes

Andy Ward and others added 2 commits March 28, 2023 07:59

Added fix to changelog

f71e085

Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>

Merge branch 'main' into main

286be20

Signed-off-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com>

JorTurFer approved these changes Mar 28, 2023

View reviewed changes

JorTurFer merged commit 04e5742 into kedacore:main Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) #4401

fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) #4401

Eldarrin commented Mar 22, 2023

JorTurFer commented Mar 24, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Mar 24, 2023 •

edited by github-actions bot

Loading

Eldarrin commented Mar 24, 2023

JorTurFer commented Mar 26, 2023

Eldarrin commented Mar 26, 2023

JorTurFer commented Mar 26, 2023

Eldarrin commented Mar 26, 2023

JorTurFer commented Mar 26, 2023

Eldarrin commented Mar 27, 2023

JorTurFer commented Mar 27, 2023

JorTurFer commented Mar 27, 2023 •

edited by github-actions bot

Loading

JorTurFer left a comment

JorTurFer left a comment

Eldarrin commented Mar 27, 2023 •

edited

Loading

JorTurFer commented Mar 28, 2023 •

edited by github-actions bot

Loading

fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) #4401

fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) #4401

Conversation

Eldarrin commented Mar 22, 2023

Checklist

JorTurFer commented Mar 24, 2023 • edited by github-actions bot Loading

JorTurFer commented Mar 24, 2023 • edited by github-actions bot Loading

Eldarrin commented Mar 24, 2023

JorTurFer commented Mar 26, 2023

Eldarrin commented Mar 26, 2023

JorTurFer commented Mar 26, 2023

Eldarrin commented Mar 26, 2023

JorTurFer commented Mar 26, 2023

Eldarrin commented Mar 27, 2023

JorTurFer commented Mar 27, 2023

JorTurFer commented Mar 27, 2023 • edited by github-actions bot Loading

JorTurFer left a comment

Choose a reason for hiding this comment

JorTurFer left a comment

Choose a reason for hiding this comment

Eldarrin commented Mar 27, 2023 • edited Loading

JorTurFer commented Mar 28, 2023 • edited by github-actions bot Loading

JorTurFer commented Mar 24, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Mar 24, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Mar 27, 2023 •

edited by github-actions bot

Loading

Eldarrin commented Mar 27, 2023 •

edited

Loading

JorTurFer commented Mar 28, 2023 •

edited by github-actions bot

Loading