Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: util functions for Status & Conditions handling #4487

Merged
merged 3 commits into from
May 19, 2023
Merged

refactor: util functions for Status & Conditions handling #4487

merged 3 commits into from
May 19, 2023

Conversation

tobotg
Copy link
Contributor

@tobotg tobotg commented Apr 30, 2023

Checklist

Fixes #2906

@tobotg tobotg requested a review from a team as a code owner April 30, 2023 22:59
@zroubalik
Copy link
Member

zroubalik commented May 2, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

Could you rebase main? There are changes required to execute the e2e tests

@zroubalik
Copy link
Member

zroubalik commented May 3, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented May 15, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik mentioned this pull request May 15, 2023
Closed
5 tasks
@zroubalik
Copy link
Member

zroubalik commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e gcp_storage
Update: You can check the progress here

zroubalik
zroubalik reviewed May 17, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you please add a entry to Changelog? TO Other section?

zroubalik
zroubalik reviewed May 17, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also rebase the PR, so we can run e2e tests against up-to-date code.

@JorTurFer
Copy link
Member

JorTurFer commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented May 18, 2023 •
edited
Loading

Looking good, could you please add a entry to Changelog? TO Other section?

Please udpate Changelog as well.

zroubalik
zroubalik reviewed May 18, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just fix the error messages to follow golang convetion.

pkg/util/status.go Outdated Show resolved Hide resolved
pkg/util/status.go Outdated Show resolved Hide resolved
pkg/util/status.go Outdated Show resolved Hide resolved
pkg/util/status.go Outdated Show resolved Hide resolved
tobotg added 3 commits May 18, 2023 16:43
@tobotg
refactor: several functions for Status & Conditions handling into pkg…
ef0baf4 
… util functions

Signed-off-by: Tobo Atchou <tobo.atchou@gmail.com>
@tobotg
refactor: several functions for Status & Conditions handling into pkg…
a3da5f4 
… util functions. add Changelog

Signed-off-by: Tobo Atchou <tobo.atchou@gmail.com>
@tobotg
refactor: several functions for Status & Conditions handling into pkg…
84fd208 
… util functions. fix error message

Signed-off-by: Tobo Atchou <tobo.atchou@gmail.com>
@tobotg
Copy link
Contributor Author

tobotg commented May 18, 2023

Looking good, just fix the error messages to follow golang convetion.

Thank you @zroubalik . Done now.

zroubalik
zroubalik approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, great job!

@zroubalik
Copy link
Member

zroubalik commented May 18, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) May 18, 2023 15:20
@zroubalik zroubalik disabled auto-merge May 18, 2023 16:02
@zroubalik zroubalik merged commit 4019401 into kedacore:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor functions for Status & Conditions handling
3 participants
@tobotg @zroubalik @JorTurFer