-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info in kubectl get triggerauthentication #4668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, would you mind adding some tests + example output please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, we should def add a tests for this.
6d811dc
to
d4765ff
Compare
It seems like adding infrastructure test should provide a new PR? I will add a PR about the test after PR merging. @tomkerkhove @zroubalik |
290a801
to
414a877
Compare
By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: spiritzhou <iammrzhouzhenghan@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: spiritzhou <iammrzhouzhenghan@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: spiritzhou <iammrzhouzhenghan@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
414a877
to
bba59be
Compare
It depends what you need. Our cluster is managed in another PR but you should be good for this PR. For e2e tests we deploy resources to the cluster which is part of the e2e rest itself so we can do it in this PR. |
Thanks, @tomkerkhove. I added a e2e test in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add a functional test here:
Describe("functional tests", func() { |
(create SO _ check TA status, remove SO check TA status again, create 2 SOs check TA).
And also create a separate test for scaledjob_controller that is testing the same.
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few nits to be done. In general it is better to add comments on every functions that do something non-trivial.
/run-e2e internal |
/run-e2e internal Update: You can check the progress here |
6065ef8
to
e949528
Compare
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
/run-e2e internal |
LGTM, but I'll leave it up to @zroubalik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks!
Add scaledobjetc/socaledjob info when kubectl get triggerauthentication/clustertriggerauthentication.
Here is more info: #796
Example:
Checklist
Fixes #796