-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Skip Resolving Secrets From Restricted Namespace #4735
fix: Skip Resolving Secrets From Restricted Namespace #4735
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
resolver % export KEDA_RESTRICT_SECRET_ACCESS=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Indresh2410 the static check is failing, there's a whitespace end the end of the new line in Makefile
diff --git a/Makefile b/Makefile
index 21e3aab..f6bfed8 100644
--- a/Makefile
+++ b/Makefile
Error: @@ -173,7 +173,7 @@ pkg/mock/mock_scaler/mock_scaler.go: pkg/scalers/scaler.go
$(MOCKGEN) -destination=$@ -package=mock_scalers -source=$^
Error: pkg/mock/mock_secretlister/mock_interfaces.go: vendor/k8s.io/client-go/listers/core/v1/secret.go
mkdir -p pkg/mock/mock_secretlister
- $(MOCKGEN) k8s.io/client-go/listers/core/v1 SecretLister,SecretNamespaceLister > $@
+ $(MOCKGEN) k8s.io/client-go/listers/core/v1 SecretLister,SecretNamespaceLister > $@
/run-e2e |
/run-e2e |
Signed-off-by: Indresh-Prakash <indreshprakash24@gmail.com>
50cc12d
to
5850a74
Compare
/run-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @zroubalik . e2e tests are oscillating . Don't see any issues wrt test cases. Any suggestion on this? |
/run-e2e azure |
Thanks @Indresh2410 ! |
Signed-off-by: Indresh-Prakash <indreshprakash24@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Indresh2410 <130135623+Indresh2410@users.noreply.github.com> fix: Skip Resolving Secrets From Restricted Namespace (#4735)
Provide a description of what has been changed
Checklist
Fixes #4519
Relates to #