-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add kafka-go based kafka scaler #4801
Conversation
- kafka tests should run in their own namespace - each kafka test case can have their own kafka cluster Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about: |
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
I was waiting for test results on how it goes performance wise in a production grade use case. Seems pretty chill so far. Putting it up for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this awesome contribution!!!
I have done a first review over majority of the code
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Souyama <souyama.debnath@atos.net>
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
- rename kafka-x to apache-kafka Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
As @JorTurFer suggested, I made the required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could you take a look @zroubalik ?
/run-e2e kafka |
Is there an update on when we think this change will be merged? Eagerly waiting on the ability to use IAM for auth. |
We are waiting @zroubalik 's review as our expert in kafka. We are in summer break but we will restore the usual speed in September, so I guess that this will be merged soon |
/run-e2e kafka |
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
- With summary of diference between kafka scaler implementation Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
/run-e2e kafka |
Just a heads up, although there were minimal changes needed to make this compatible with v2, haven't tested it with a cluster yet. Should not break anything, but will get around to testing it by mid of next week. |
5648ca4
to
4f87694
Compare
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
bc010ba
to
fcf7276
Compare
/run-e2e kafka |
Awesome, thanks for the great work! Keep us posted. |
Everything's working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work! Thanks
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net> Signed-off-by: Souyama <souyama.debnath@atos.net> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: anton.lysina <alysina@gmail.com>
Add experimental kafka scaler based on kafka-go
apache-kafka
.Changes to e2e test cases for concurrent testing of multiple kafka scalers.
Upgrade kafka version used for e2e testing.
Checklist
Fixes #4692 #3431
Relates to kedacore/keda-docs#1187