Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tls authentication for redis scaler #4979

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add tls authentication for redis scaler #4979

merged 2 commits into from
Sep 25, 2023

Conversation

Taction
Copy link
Contributor

@Taction Taction commented Sep 17, 2023 •
edited
Loading

Provide a description of what has been changed

Allow defining TLS config in TriggerAuthentication for Redis scaler.

Checklist

Fixes #4917

Relates to #

@Taction Taction requested a review from a team as a code owner September 17, 2023 08:54
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
Copy link
Member

Looking good but there are still some things to do, could you update docs and the changelog please?
Does adding this to redis stream too make sense?

zroubalik
zroubalik reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looking good, agree with @JorTurFer's points

@Taction
add tls for redis scaler
97ee4e9 
Signed-off-by: zhangchao <zchao9100@gmail.com>
@Taction
add change log and add tls to stream
c5f5265 
Signed-off-by: zhangchao <zchao9100@gmail.com>
@Taction
Copy link
Contributor Author

Taction commented Sep 19, 2023

Thanks for your review, done.

@JorTurFer
Copy link
Member

JorTurFer commented Sep 19, 2023 •
edited by github-actions bot
Loading

/run-e2e redis
Update: You can check the progress here

JorTurFer
JorTurFer approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

zroubalik
zroubalik approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taction Taction mentioned this pull request Sep 24, 2023
Merged
1 task
@zroubalik zroubalik merged commit d577233 into kedacore:main Sep 25, 2023
19 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@Taction @toniiiik
Add tls authentication for redis scaler (kedacore#4979)
b3dc3bf 
Signed-off-by: zhangchao <zchao9100@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use Redis Scaler with TLS authentication？
3 participants
@Taction @JorTurFer @zroubalik