Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger in OTEL collector #5095

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix logger in OTEL collector #5095

merged 1 commit into from
Oct 18, 2023

Conversation

zroubalik
Copy link
Member

  • wrong logger
  • removing some fmt.Printl() commands

Checklist

Fixes #5094

@zroubalik
Fix logger in otel collector
4bc1d02 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik requested a review from a team as a code owner October 18, 2023 11:28
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@zroubalik
Copy link
Member Author

zroubalik commented Oct 18, 2023 •
edited by github-actions bot
Loading

/run-e2e opentelemetry_metrics
Update: You can check the progress here

@zroubalik zroubalik mentioned this pull request Oct 18, 2023
Merged
5 tasks
@JorTurFer JorTurFer merged commit 3d00a09 into kedacore:main Oct 18, 2023
20 checks passed
zroubalik added a commit to zroubalik/keda that referenced this pull request Nov 27, 2023
@zroubalik
Fix logger in OTEL collector (kedacore#5095)
3e2ed4b
zroubalik added a commit to zroubalik/keda that referenced this pull request Nov 27, 2023
@zroubalik
Fix logger in OTEL collector (kedacore#5095)
d7d8be5 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
zroubalik added a commit to zroubalik/keda that referenced this pull request Nov 27, 2023
@zroubalik
Fix logger in OTEL collector (kedacore#5095)
5e31231 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
zroubalik added a commit that referenced this pull request Nov 27, 2023
@zroubalik
Fix logger in OTEL collector (#5095)
45d5872 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@zroubalik @toniiiik
Fix logger in OTEL collector (kedacore#5095)
266bb1d 
Signed-off-by: anton.lysina <alysina@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTEL collector error logging is wrong
2 participants
@zroubalik @JorTurFer