fix: URL encode poolName in azure-pipelines #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chunderbolt <59027738+chunderbolt@users.noreply.github.com>
Signed-off-by: Chunderbolt <59027738+chunderbolt@users.noreply.github.com>
Signed-off-by: Chunderbolt <59027738+chunderbolt@users.noreply.github.com>
Signed-off-by: Chunderbolt <59027738+chunderbolt@users.noreply.github.com>
Signed-off-by: Chunderbolt <59027738+chunderbolt@users.noreply.github.com>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
|
/run-e2e pipeline |
JorTurFer
reviewed
Oct 23, 2023
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
|
/skip-e2e |
JorTurFer
approved these changes
Oct 23, 2023
zroubalik
pushed a commit
to zroubalik/keda
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
zroubalik
pushed a commit
to zroubalik/keda
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
zroubalik
pushed a commit
to zroubalik/keda
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
zroubalik
pushed a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, having a space in the pool name would cause HTTP 400 responses from ADO which lead to metadata parsing errors from KEDA. This should no longer happen now that the pool name is escaped.
Checklist
Fixes #5107
I've added a test to the existing file (fails before, passes now) but I'm not properly set up to integration test this - I hadn't written any Go since <100 lines 5 years ago so I had to do a bunch of setup already. Should work, it's not exactly complicated.
Also changed
urlvars in the file tourlString.