Fix: GCP pubsub / cloud tasks metric queries for metric scoped projects #5258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Pait <david.pait@pendo.io>
Signed-off-by: David Pait <david.pait@pendo.io>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Signed-off-by: David Pait <david.pait@pendo.io>
|
/run-e2e gcp |
JorTurFer
approved these changes
Dec 6, 2023
6 tasks
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
…ts (kedacore#5258) Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
resource.labels.project_idto filter for metrics client queries in gcp. If a project is using metrics scoping and is also a project that contains pub/sub or cloud tasks; looking at metrics in that project will show data from scoped projects as well. Filtering this down to the project we're querying in resolves the issueChecklist
Fixes #5256