CPU Scaler: Make CPU scaler test wait for metrics window #5294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPU scaler tests assume the default metrics-server window of
30s
, so those testing on platforms with larger metrics windows (e.g. platforms using prometheus-adapter, which has a5m
default window) will fail the CPU scaler test because the metrics won't be ready by the time the test starts.This:
Output looks like this when it runs:
Checklist
When introducing a new scaler, I agree with the scaling governance policyTests have been addedA PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)A PR is opened to update the documentation on (repo) (if applicable)