Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service bus scaler pod identity fix #534

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Service bus scaler pod identity fix #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
398e873
Remove short variable declaration in inner block
privalof Jan 7, 2020
eaf5a0c
Added PodIdentity test for service bus scaler
privalof Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/scalers/azure_servicebus_scaler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func (s *azureServiceBusScaler) GetAzureServiceBusLength(ctx context.Context) (i
return -1, err
}
} else if s.podIdentity == "azure" {
namespace, err := servicebus.NewNamespace()
namespace, err = servicebus.NewNamespace()
if err != nil {
return -1, err
}
Expand Down
6 changes: 6 additions & 0 deletions pkg/scalers/azure_servicebus_scaler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ var getServiceBusLengthTestScalers = []azureServiceBusScaler{
topicName: topicName,
subscriptionName: subscriptionName,
}},
{metadata: &azureServiceBusMetadata{
entityType: Subscription,
topicName: topicName,
subscriptionName: subscriptionName,
},
podIdentity: "azure"},
}

func TestParseServiceBusMetadata(t *testing.T) {
Expand Down