Refactored fallback logic to only patch status when the fallback is e… #5659
Conversation
…nabled Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
There was a problem hiding this comment.
LGTM! Could you update the changelog linking the fixed issue? I think that improvements can be the better fit considering that this will improve the performance.
@zroubalik @dttung2905 PTAL if you have time :)
|
/run-e2e |
|
@bharathguvvala , could you check the failing CI checks? I think that unit tests probably need to be updated as they expect the call to |
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@zroubalik Apologies about the delay. I'll close this within a week before Jun 14. |
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Bharath Raghavendra Reddy Guvvala <bharath.raghavendra@gmail.com>
no worries, thanks for the update! |
There was a problem hiding this comment.
@bharathguvvala there are still failures in static checks and unit tests
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
bharathguvvala
force-pushed
the
upstreammain
branch
from
e014c1b to
44b169b
Compare
|
/run-e2e |
|
@zroubalik there are some queued check. How do I get them to execute? |
|
How does this relate to #5871 ? |
|
/run-e2e |
|
/run-e2e |
|
@zroubalik can we please merge these changes since the E2E have passed? |
|
/run-e2e |
|
The e2e failure isn't related with this changes |
|
/run-e2e internal |
kedacore#5659) * refactored fallback logic to only patch status when the fallback is enabled Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * removed newline Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * formatted imports Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * WIP: verifying test failure fixes Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * WIP: verifying test failure fixes Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * WIP: verifying test failure fixes Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * WIP: verifying test failure fixes Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * WIP: verifying test failure fixes Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * Update pkg/fallback/fallback.go Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Bharath Raghavendra Reddy Guvvala <bharath.raghavendra@gmail.com> * fixed test failures Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> * fixed test failures Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> --------- Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com> Signed-off-by: Bharath Raghavendra Reddy Guvvala <bharath.raghavendra@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
…nabled
This change ensures that the update health status of the scaledObjects is only updated when the fallback configuration is enabled on the scaledobject. Further optimizations to avoid redundant updates when the status doesn't change can be done later. Tests will be added, if the change is ratified by the maintainers.
Checklist
Fixes #5624