Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ClusterCloudEventSource #5816

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented May 21, 2024

Introduce ClusterCloudEventSource

Checklist

Relates to #3533

@SpiritZhou SpiritZhou requested a review from a team as a code owner May 21, 2024 06:11
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick skim and think it looks OK but not a go expert. @JorTurFer Can you share your wisdom?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick skim and think it looks OK but not a go expert. @JorTurFer Can you share your wisdom?

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is on the right track, but I would like us to try to reduce the code duplication a bit ideally.

I created a sample PR to communicate my ideas better in #5924, most importantly I think we should explore some options to not copy-paste the reconciler. #5924 discusses one potential way how this might be achievable, ptal

controllers/eventing/clustercloudeventsource_controller.go Outdated Show resolved Hide resolved
apis/eventing/v1alpha1/cloudeventsource_types.go Outdated Show resolved Hide resolved
apis/eventing/v1alpha1/cloudeventsource_types.go Outdated Show resolved Hide resolved
cmd/operator/main.go Show resolved Hide resolved
@SpiritZhou
Copy link
Contributor Author

I think this is on the right track, but I would like us to try to reduce the code duplication a bit ideally.

I created a sample PR to communicate my ideas better in #5924, most importantly I think we should explore some options to not copy-paste the reconciler. #5924 discusses one potential way how this might be achievable, ptal

Thanks @wozniakjan, I think triggerauthentication & clustertriggerauthentication can be refactor as well.

@wozniakjan
Copy link
Member

Thanks @wozniakjan, I think triggerauthentication & clustertriggerauthentication can be refactor as well.

That is a good point, I will try to find some time later this month to check for any code duplication candidates for TA and CTA

SpiritZhou and others added 5 commits July 15, 2024 11:15
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@tomkerkhove
Copy link
Member

tomkerkhove commented Jul 15, 2024

/run-e2e cloud*
Update: You can check the progress here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants