-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ClusterCloudEventSource #5816
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick skim and think it looks OK but not a go expert. @JorTurFer Can you share your wisdom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick skim and think it looks OK but not a go expert. @JorTurFer Can you share your wisdom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is on the right track, but I would like us to try to reduce the code duplication a bit ideally.
I created a sample PR to communicate my ideas better in #5924, most importantly I think we should explore some options to not copy-paste the reconciler. #5924 discusses one potential way how this might be achievable, ptal
Thanks @wozniakjan, I think triggerauthentication & clustertriggerauthentication can be refactor as well. |
That is a good point, I will try to find some time later this month to check for any code duplication candidates for TA and CTA |
cfdbaef
to
370fefe
Compare
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
370fefe
to
bdee6c9
Compare
/run-e2e cloud* |
Introduce ClusterCloudEventSource
Checklist
Relates to #3533