Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for Kubernetes v1.30 in KEDA v2.14 #5830

Open
wants to merge 1 commit into
base: release/v2.14
Choose a base branch
from

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented May 28, 2024

Support for Kubernetes v1.30 in KEDA v2.14

Checklist

Relates to #5828

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove requested a review from a team as a code owner May 28, 2024 06:48
@tomkerkhove
Copy link
Member Author

tomkerkhove commented May 28, 2024

/run-e2e *
Update: You can check the progress here

@JorTurFer
Copy link
Member

k8s 1.30 isn't still available on Azure, I'd wait until it's available to test that KEDA works well

@tomkerkhove
Copy link
Member Author

Totally agree!

@pavlospt
Copy link

pavlospt commented Jul 5, 2024

k8s 1.30 isn't still available on Azure, I'd wait until it's available to test that KEDA works well

Is that a reasonable action path though? Kubernetes 1.30 is available in other Cloud providers 🤔

@tomkerkhove
Copy link
Member Author

Well we don't have test clusters there so 🤷‍♂️

@pavlospt
Copy link

pavlospt commented Jul 6, 2024

Well we don't have test clusters there so 🤷‍♂️

KEDA is a CNCF Graduated project. I am sure there should be something like open source credits for the other cloud providers too. Why not apply for such programs in order to have a better test bed?

@tomkerkhove
Copy link
Member Author

We do have these, but maintaining e2e tests across 3 clusters in 3 cloud providers is not something we have today. Additionally, these credits are not infinite.

We are open to feedback, but do rely on the community so if this is something you want to contribute than I am sure @kedacore/keda-maintainers are open to review suggestions.

@pavlospt
Copy link

pavlospt commented Jul 8, 2024

We do have these, but maintaining e2e tests across 3 clusters in 3 cloud providers is not something we have today. Additionally, these credits are not infinite.

We are open to feedback, but do rely on the community so if this is something you want to contribute than I am sure @kedacore/keda-maintainers are open to review suggestions.

So you would need help in the infrastructure side of this? Open to help in any way I can!

@tomkerkhove
Copy link
Member Author

Please open a seperate issue for this, but first @kedacore/keda-maintainers need to decide if we want to go there and if it's worth the overhead. We have very little integration with cloud providers, actually almost none for clusters so it needs to be worth it.

The changes would involve:

  • Infra structure
  • Testing integration & workflows
  • Increased PR duration
  • ...

One does not simply do this =)

@pavlospt
Copy link

pavlospt commented Jul 8, 2024

Please open a seperate issue for this, but first @kedacore/keda-maintainers need to decide if we want to go there and if it's worth the overhead. We have very little integration with cloud providers, actually almost none for clusters so it needs to be worth it.

The changes would involve:

  • Infra structure
  • Testing integration & workflows
  • Increased PR duration
  • ...

One does not simply do this =)

Ok but if it's not a matter of effort then but a matter of opinion, this would lock KEDA compatibility to the Kubernetes version availability on AKS, which to me also sounds a bit restricting in comparison to increased PR duration, but wider cloud provider check!

@tomkerkhove
Copy link
Member Author

Please open a seperate issue for this

☝️

@JorTurFer
Copy link
Member

this would lock KEDA compatibility to the Kubernetes version availability on AKS

I don't think so tbh. KEDA works on multiple k8s versions, the only point is that we don't say that it's officially supported until we have test coverage with a real k8s cluster. You can use it with k8s 1.30 as you can use it with k8s 1.26.

We are willing to change and use other providers (or include them), but it requires an effort and also to maintain them. Azure gave us a great budget and other providers gave us a limited budget that we need to organice as better as we can to not waste it because we need it for testing the services themselves.

As @tomkerkhove has said, please open an issue to talk about this, if you have a proposal that covers these things, we can do it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants