Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requireAllDemandsAndIgnoreOthers flag #5839

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

Nohac
Copy link

@Nohac Nohac commented May 30, 2024

This PR adds an extra option requireAllDemandsAndIgnoreOthers (name tbd) to the azure pipeline scaler which ensures that all demands in the scaler definition is present in the incoming job, while ignoring any other demands the job may have.

This is different from requireAllDemands which requires all demands to be an exact match.

Checklist

Fixes #5579

Copy link

semgrep-app bot commented May 30, 2024

Semgrep found 1 context-todo finding:

  • pkg/scalers/azure_pipelines_scaler_test.go

Consider to use well-defined context

Ignore this finding from context-todo.

Semgrep found 1 no-direct-write-to-responsewriter finding:

  • pkg/scalers/azure_pipelines_scaler_test.go

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

Ignore this finding from no-direct-write-to-responsewriter.

Copy link

semgrep-app bot commented Jun 3, 2024

Semgrep found 1 context-todo finding:

  • pkg/scalers/azure_pipelines_scaler_test.go

Consider to use well-defined context

Ignore this finding from context-todo.

Semgrep found 1 no-direct-write-to-responsewriter finding:

  • pkg/scalers/azure_pipelines_scaler_test.go

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

Ignore this finding from no-direct-write-to-responsewriter.

Copy link

stale bot commented Aug 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Aug 2, 2024
Copy link

stale bot commented Aug 9, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this Aug 9, 2024
@JorTurFer JorTurFer reopened this Sep 2, 2024
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Sep 2, 2024
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the DCO check and update the changelog too?

@JorTurFer
Copy link
Member

JorTurFer commented Sep 2, 2024

/run-e2e pipeline
Update: You can check the progress here

Copy link

semgrep-app bot commented Sep 2, 2024

Semgrep found 1 context-todo finding:

  • pkg/scalers/azure_pipelines_scaler_test.go

Consider to use well-defined context

Ignore this finding from context-todo.

Semgrep found 1 no-direct-write-to-responsewriter finding:

  • pkg/scalers/azure_pipelines_scaler_test.go

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

Ignore this finding from no-direct-write-to-responsewriter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending the Azure DevOps Agent scaling - possibility to "ignore" demands
3 participants