Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scale with windows nodes in cluster issue 4908 #5917

Closed
wants to merge 39 commits into from
Closed

fix scale with windows nodes in cluster issue 4908 #5917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
7943f09
fix scale with windows nodes in cluster issue 4908
Jun 27, 2024
ff0c353
review fixes
Jul 2, 2024
a6d9f73
Add additional manifest checks to detect missing CRDs & CRs (#5921)
joelsmith Jul 1, 2024
c49ad9b
Add Splunk scaler (#5905)
circa10a Jul 1, 2024
d7ee1b5
Update estimated release dates (#5942)
zroubalik Jul 3, 2024
d60b371
Update github.com/hashicorp/go-retryablehttp for CVE-2024-6104 (#5945)
joelsmith Jul 8, 2024
5a9a823
chore(deps): update actions/upload-artifact digest to 0b2256b (#5950)
renovate[bot] Jul 8, 2024
10547f1
Provide CloudEvents around the management of ScaledObjects resources …
SpiritZhou Jul 10, 2024
8db4090
fix scaler and tests
Aug 1, 2024
32966e1
Add username from env mysql scaler (#5952)
Indresh2410 Jul 22, 2024
8412f6b
Return the error if TLS config fails in Rabbitmq scaler (#5964)
semihbkgr Jul 22, 2024
6697ce1
chore(deps): update github actions (#5957)
renovate[bot] Jul 22, 2024
1e01186
Migrate old Azure SDKs into to use `github.com/Azure/azure-sdk-for-go…
JorTurFer Jul 24, 2024
b0d891a
feat: add TLS support for IBM MQ scaler (#5976)
rickbrouwer Jul 25, 2024
0051955
feat: GCP Pub/Sub scaler add configurable fallback value when no metr…
Caislear Jul 25, 2024
f338ae3
fix: Exclude test files from semgrep scan (#5982)
JorTurFer Jul 25, 2024
f647037
fix: use AMD machines again for semgrep workflow (#5983)
JorTurFer Jul 25, 2024
01715b9
add core logic to support access token in postgres scaler (#5589)
Ferdinanddb Jul 29, 2024
9a55f34
Add missing TestNamespace to ScaledJob validation test template (#5989)
jkyros Jul 29, 2024
c5702b7
chore: Use CNCF runner to execute PR e2e tests (#5992)
JorTurFer Jul 29, 2024
0764461
Add option to the Datadog scaler to use the Cluster Agent as proxy (#…
arapulido Jul 29, 2024
9cc1663
chore: Update supported versions (#5993)
JorTurFer Jul 30, 2024
5d58ced
fix: Revert equinix change (#5999)
JorTurFer Jul 30, 2024
1ccbe6a
Update GetAzureQueueLength in azure storage queue scaler to consider …
leodip Jul 30, 2024
b5865c6
Add eagerScalingStrategy for ScaledJob (#5872)
junekhan Jul 30, 2024
d69b00f
[BUG-5656] Annotate Jobs with parent ScaledJob generation (#5876)
josefkarasek Jul 30, 2024
26e9672
chore: Update e2e image (#6000)
JorTurFer Jul 30, 2024
f5b549f
[BUG-5922] Report failing ScaledJob triggers in status (#5916)
josefkarasek Jul 30, 2024
f886fca
chore: build with keda-tools:1.22.5 (#5971)
pauldotyu Jul 30, 2024
2bc0d63
remove unused leader election parameters of metrics adapter (#5986)
lantingchiang Jul 30, 2024
07d89b4
feat: Dynatrace scaler (#5685)
cyrilico Jul 30, 2024
4eb4eed
chore: Disable temporally AzPipeline WI e2e (#6003)
JorTurFer Jul 30, 2024
71785c1
chore: Prepare main branch for v2.14.1 (#6007)
JorTurFer Jul 31, 2024
18ed515
Remove deprecated cortexOrgId in prometheus scaler (#5990)
dttung2905 Jul 31, 2024
409d9a9
fix: reassign err to prevent invalid return in KedaProvider `GetExter…
maxcao13 Jul 31, 2024
32ee3a3
fix
Aug 1, 2024
eea7dcd
Signed-off-by: Doofus100500 <doofus100500@gmail.com>
Aug 1, 2024
eec6acd
Merge branch 'main' into fix-selenium-scaler
Doofus100500 Aug 1, 2024
21a9e1a
Merge branch 'main' into fix-selenium-scaler
Doofus100500 Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/scalers/selenium_grid_scaler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ type seleniumSession struct {
ID string `json:"id"`
Capabilities string `json:"capabilities"`
NodeID string `json:"nodeId"`
PlatformName string `json:"platformName"`
}

type capability struct {
Expand Down Expand Up @@ -152,7 +153,7 @@ func (s *seleniumGridScaler) GetMetricSpecForScaling(context.Context) []v2.Metri

func (s *seleniumGridScaler) getSessionsCount(ctx context.Context, logger logr.Logger) (int64, error) {
body, err := json.Marshal(map[string]string{
"query": "{ grid { maxSession, nodeCount }, sessionsInfo { sessionQueueRequests, sessions { id, capabilities, nodeId } } }",
"query": "{ grid { maxSession, nodeCount }, sessionsInfo { sessionQueueRequests, sessions { id, capabilities, nodeId, platformName } } }",
})

if err != nil {
Expand Down