-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Proposal for PR changes on ClusterCloudEventSource #5924
Closed
wozniakjan
wants to merge
2
commits into
kedacore:main
from
wozniakjan:simple_ClusterCloudEventSource
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
140 changes: 140 additions & 0 deletions
140
config/crd/bases/eventing.keda.sh_clustercloudeventsources.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,140 @@ | ||
--- | ||
apiVersion: apiextensions.k8s.io/v1 | ||
kind: CustomResourceDefinition | ||
metadata: | ||
annotations: | ||
controller-gen.kubebuilder.io/version: v0.14.0 | ||
name: clustercloudeventsources.eventing.keda.sh | ||
spec: | ||
group: eventing.keda.sh | ||
names: | ||
kind: ClusterCloudEventSource | ||
listKind: ClusterCloudEventSourceList | ||
plural: clustercloudeventsources | ||
singular: clustercloudeventsource | ||
scope: Cluster | ||
versions: | ||
- additionalPrinterColumns: | ||
- jsonPath: .status.conditions[?(@.type=="Active")].status | ||
name: Active | ||
type: string | ||
name: v1alpha1 | ||
schema: | ||
openAPIV3Schema: | ||
description: ClusterCloudEventSource defines how a KEDA event will be sent | ||
to event sink on cluster level | ||
properties: | ||
apiVersion: | ||
description: |- | ||
APIVersion defines the versioned schema of this representation of an object. | ||
Servers should convert recognized schemas to the latest internal value, and | ||
may reject unrecognized values. | ||
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources | ||
type: string | ||
kind: | ||
description: |- | ||
Kind is a string value representing the REST resource this object represents. | ||
Servers may infer this from the endpoint the client submits requests to. | ||
Cannot be updated. | ||
In CamelCase. | ||
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds | ||
type: string | ||
metadata: | ||
type: object | ||
spec: | ||
description: CloudEventSourceSpec defines the spec of CloudEventSource | ||
properties: | ||
authenticationRef: | ||
description: |- | ||
AuthenticationRef points to the TriggerAuthentication or ClusterTriggerAuthentication object that | ||
is used to authenticate the scaler with the environment | ||
properties: | ||
kind: | ||
description: Kind of the resource being referred to. Defaults | ||
to TriggerAuthentication. | ||
type: string | ||
name: | ||
type: string | ||
required: | ||
- name | ||
type: object | ||
clusterName: | ||
type: string | ||
destination: | ||
description: Destination defines the various ways to emit events | ||
properties: | ||
azureEventGridTopic: | ||
properties: | ||
endpoint: | ||
type: string | ||
required: | ||
- endpoint | ||
type: object | ||
http: | ||
properties: | ||
uri: | ||
type: string | ||
required: | ||
- uri | ||
type: object | ||
type: object | ||
eventSubscription: | ||
description: EventSubscription defines filters for events | ||
properties: | ||
excludedEventTypes: | ||
items: | ||
description: CloudEventType contains the list of cloudevent | ||
types | ||
enum: | ||
- keda.scaledobject.ready.v1 | ||
- keda.scaledobject.failed.v1 | ||
type: string | ||
type: array | ||
includedEventTypes: | ||
items: | ||
description: CloudEventType contains the list of cloudevent | ||
types | ||
enum: | ||
- keda.scaledobject.ready.v1 | ||
- keda.scaledobject.failed.v1 | ||
type: string | ||
type: array | ||
type: object | ||
required: | ||
- destination | ||
type: object | ||
status: | ||
description: CloudEventSourceStatus defines the observed state of CloudEventSource | ||
properties: | ||
conditions: | ||
description: Conditions an array representation to store multiple | ||
Conditions | ||
items: | ||
description: Condition to store the condition state | ||
properties: | ||
message: | ||
description: A human readable message indicating details about | ||
the transition. | ||
type: string | ||
reason: | ||
description: The reason for the condition's last transition. | ||
type: string | ||
status: | ||
description: Status of the condition, one of True, False, Unknown. | ||
type: string | ||
type: | ||
description: Type of condition | ||
type: string | ||
required: | ||
- status | ||
- type | ||
type: object | ||
type: array | ||
type: object | ||
required: | ||
- spec | ||
type: object | ||
served: true | ||
storage: true | ||
subresources: | ||
status: {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reconciliation cannot accept multiple objects. I think we should still set up multiple controllers and eliminate the duplicates through abstraction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, you are right, it's been a long time since I used that pattern. Looks like this was supported in controller-runtime older than 0.7.0 but is no longer an option since kubernetes-sigs/controller-runtime#1176