Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full triggers and authentications in status #6232

Merged
merged 16 commits into from
Nov 5, 2024
Merged

Show full triggers and authentications in status #6232

merged 16 commits into from
Nov 5, 2024

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Oct 11, 2024 •
edited by zroubalik
Loading

Show full triggers and authentications in status

image

Checklist

  • [N/A] When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [N/A] A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6187
Fixes #1943

@SpiritZhou SpiritZhou requested a review from a team as a code owner October 11, 2024 07:31
JorTurFer
JorTurFer approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just 2 small updates inline.
PTAL @kedacore/keda-core-contributors

tests/internals/status_update/status_update_test.go Outdated Show resolved Hide resolved
tests/internals/status_update/status_update_test.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Oct 16, 2024 •
edited by github-actions bot
Loading

/run-e2e status_update_test
Update: You can check the progress here

SpiritZhou and others added 6 commits October 21, 2024 13:23
@SpiritZhou @wozniakjan
Update
9bcbe99 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @wozniakjan
Fix
10a20a8 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @wozniakjan
Fix
9600e2f 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @wozniakjan
Fix
d022250 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @JorTurFer @wozniakjan
Update tests/internals/status_update/status_update_test.go
a68611c 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @JorTurFer @wozniakjan
Update tests/internals/status_update/status_update_test.go
146a0f7 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@wozniakjan wozniakjan force-pushed the spiritzhou/fulltriggername branch from ecf711d to 146a0f7 Compare October 21, 2024 11:23
zroubalik
zroubalik reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, just some nits around naming.

apis/keda/v1alpha1/scaledjob_types.go Outdated Show resolved Hide resolved
apis/keda/v1alpha1/scaledjob_types.go Outdated Show resolved Hide resolved
apis/keda/v1alpha1/scaledobject_types.go Outdated Show resolved Hide resolved
apis/keda/v1alpha1/scaletriggers_types.go Outdated Show resolved Hide resolved
SpiritZhou and others added 10 commits October 24, 2024 10:46
@SpiritZhou @zroubalik
Update apis/keda/v1alpha1/scaledjob_types.go
b1c88b4 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @zroubalik
Update apis/keda/v1alpha1/scaledjob_types.go
3e4379b 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @zroubalik
Update apis/keda/v1alpha1/scaletriggers_types.go
2643f66 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Merge branch 'main' into spiritzhou/fulltriggername
f20078b 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
63e0a1e 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update "name" to "type"
786aeb8 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
90244d2 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
0b0a76e 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
e03c00f 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Merge branch 'main' into spiritzhou/fulltriggername
eae8ab5
@JorTurFer JorTurFer mentioned this pull request Nov 3, 2024
Closed
28 tasks
@SpiritZhou SpiritZhou mentioned this pull request Nov 4, 2024
Merged
4 tasks
@JorTurFer
Copy link
Member

JorTurFer commented Nov 4, 2024 •
edited by github-actions bot
Loading

/run-e2e status_update_test
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) November 4, 2024 08:16
@wozniakjan
Copy link
Member

@SpiritZhou maybe we can consider adding docs PR as well, but feel free to remove other two unchecked items from the checklist regarding new scaler and helm chart PR

zroubalik
zroubalik approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer JorTurFer merged commit 96c2ba3 into kedacore:main Nov 5, 2024
19 of 20 checks passed
@zroubalik
Copy link
Member

@SpiritZhou maybe we can consider adding docs PR as well, but feel free to remove other two unchecked items from the checklist regarding new scaler and helm chart PR

Fixed, I don't think we need any docs for this.

mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
@SpiritZhou @JorTurFer
@zroubalik @mpechner-akasa
Show full triggers and authentications in status (kedacore#6232)
9d0c0cd 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl get scaledobject does not show external triggers kubectl get scaledobject only displays one trigger
4 participants
@SpiritZhou @JorTurFer @wozniakjan @zroubalik