Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to not scale GitHub runner on default runner labels #6251

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

leevilehtonen
Copy link
Contributor

@leevilehtonen leevilehtonen commented Oct 20, 2024

Add new option to not scale GitHub runner on default runner labels

Checklist

  • [N/A] When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6127

Relates kedacore/keda-docs#1492

Copy link

semgrep-app bot commented Oct 20, 2024

Semgrep found 3 context-todo findings:

Consider to use well-defined context

Ignore this finding from context-todo.

@leevilehtonen leevilehtonen marked this pull request as ready for review October 20, 2024 14:15
@leevilehtonen leevilehtonen requested a review from a team as a code owner October 20, 2024 14:15
@leevilehtonen
Copy link
Contributor Author

Selenium tests probably fixed in #6246

@JorTurFer
Copy link
Member

could you update docs as well?

@leevilehtonen
Copy link
Contributor Author

could you update docs as well?

I'll try to get them done this week

Copy link

semgrep-app bot commented Oct 26, 2024

Semgrep found 1 context-todo finding:

  • pkg/scalers/github_runner_scaler_test.go

Consider to use well-defined context

Ignore this finding from context-todo.

@leevilehtonen
Copy link
Contributor Author

could you update docs as well?

I'll try to get them done this week

Docs updated on kedacore/keda-docs#1492

pkg/scalers/github_runner_scaler_test.go Outdated Show resolved Hide resolved
pkg/scalers/github_runner_scaler_test.go Outdated Show resolved Hide resolved
pkg/scalers/github_runner_scaler_test.go Outdated Show resolved Hide resolved
pkg/scalers/github_runner_scaler_test.go Outdated Show resolved Hide resolved
Signed-off-by: Leevi Lehtonen <leevi.k.lehtonen@gmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Nov 3, 2024

/run-e2e github
Update: You can check the progress here

@zroubalik zroubalik merged commit 1e90416 into kedacore:main Nov 5, 2024
20 checks passed
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
…kedacore#6251)

Signed-off-by: Leevi Lehtonen <leevi.k.lehtonen@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
…kedacore#6251)

Signed-off-by: Leevi Lehtonen <leevi.k.lehtonen@gmail.com>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github-runner-scaler always scales with default labels
3 participants