Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scaledjobs stuck as not ready #6329

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

msvticket
Copy link
Contributor

@msvticket msvticket commented Nov 12, 2024

Since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem

Checklist

This is a fix for a regression in #5916

since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem

This is a fix for a regression in kedacore#5916

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik
Copy link
Member

zroubalik commented Nov 18, 2024

/run-e2e internal
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 9831734 into kedacore:main Nov 23, 2024
20 checks passed
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem

This is a fix for a regression in kedacore#5916

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
robpickerill pushed a commit to robpickerill/keda that referenced this pull request Nov 30, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem

This is a fix for a regression in kedacore#5916

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem

This is a fix for a regression in kedacore#5916

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem

This is a fix for a regression in kedacore#5916

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem

This is a fix for a regression in kedacore#5916

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants