Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Streams Scaler #765

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Conversation

abhirockzz
Copy link
Contributor

@abhirockzz abhirockzz commented Apr 20, 2020

Redis Streams, a data type introduced with Redis 5.0 is an append-only log data structure. One of its features includes "consumer groups" that allows a group of clients to co-operate consuming a different portion of the same stream of messages.

This scaler can check the Pending Entries List (see XPENDING https://redis.io/commands/xpending) for a specific Consumer Group of a Redis Stream and scale-out the Deployment as per the count returned (by XPENDING command). If you have a Redis Streams consumer application that is unable to keep up with the rate of production, KEDA can help by auto-scaling the no. of instances (part of the same consumer group) so that it can start sharing the processing workload.

Checklist

Fixes #746

Signed-off-by: abhishek <abhirockzz@gmail.com>
@tomkerkhove
Copy link
Member

Thanks man - Let me know when there are docs to review!

@abhirockzz
Copy link
Contributor Author

Thanks man - Let me know when there are docs to review!

Docs PR - kedacore/keda-docs#147

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have experience with Redis Streams, but the code looks good

@zroubalik
Copy link
Member

@abhirockzz do you think it would be possible to add e2d tests for Redis Streams Scaler?

https://github.com/kedacore/keda/tree/master/tests#adding-tests

@abhirockzz
Copy link
Contributor Author

@abhirockzz do you think it would be possible to add e2d tests for Redis Streams Scaler?

https://github.com/kedacore/keda/tree/master/tests#adding-tests

will try my best @zroubalik :) let me look into this

@zroubalik
Copy link
Member

@abhirockzz just FYI, similar tests for RabbitMQ were just added, so you can check them out: #810

@abhirockzz
Copy link
Contributor Author

@abhirockzz just FYI, similar tests for RabbitMQ were just added, so you can check them out: #810

Thanks! I am not familiar with TS, so an existing impl should be helpful

@zroubalik
Copy link
Member

@abhirockzz any update on this please? Or do you need any help?

@abhirockzz
Copy link
Contributor Author

@abhirockzz any update on this please? Or do you need any help?

sorry for the delay. I am working on this and will keep you posted

@zroubalik
Copy link
Member

@abhirockzz no worries, I was just concerned whether you need some help. Thanks!

Signed-off-by: abhishek <abhirockzz@gmail.com>
@zroubalik
Copy link
Member

@idvoretskyi @ahmelsayed FOSSA failed here for missing FOSSA API key again? 🤷‍♂️

@idvoretskyi
Copy link
Contributor

@zroubalik the same issue, I assume. The secrets are not passed to the PR from fork.

@zroubalik
Copy link
Member

zroubalik commented Jun 8, 2020

@idvoretskyi so we should do something about this, failing checks in PR are not ideal. How is the FOSSA done in other projects?

@idvoretskyi
Copy link
Contributor

Ref on the FOSSA check - #808 (comment)

@zroubalik zroubalik merged commit c4acdc9 into kedacore:master Jun 17, 2020
tbickford pushed a commit to tbickford/keda that referenced this pull request Jun 21, 2020
Signed-off-by: abhishek <abhirockzz@gmail.com>
@ahmelsayed ahmelsayed mentioned this pull request Aug 11, 2020
3 tasks
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KEDA scaler for Redis Streams
4 participants