Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] generate CRD shortnames #793

Merged
merged 1 commit into from
Apr 29, 2020
Merged

[v2] generate CRD shortnames #793

merged 1 commit into from
Apr 29, 2020

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Generate CRD shortnames so they can be used with kubectl get

scaledObject - so
scaledJob - sj
triggerAuthentication - ta, triggerauth

Fixes #774

generate CRD shortnames
0b1338c 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik requested a review from tomkerkhove April 29, 2020 11:00
@zroubalik zroubalik requested a review from ahmelsayed as a code owner April 29, 2020 11:00
tomkerkhove
tomkerkhove approved these changes Apr 29, 2020
View reviewed changes
deploy/crds/keda.sh_scaledjobs_crd.yaml
@@ -3,11 +3,26 @@ kind: CustomResourceDefinition
metadata:
name: scaledjobs.keda.sh
spec:
additionalPrinterColumns:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to close #777 as well then or at least relate to it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add more details in the following PR to fully cover #777

@zroubalik zroubalik merged commit ccd01cf into kedacore:v2 Apr 29, 2020
@zroubalik zroubalik mentioned this pull request Apr 29, 2020
Closed
@zroubalik zroubalik deleted the shortnames branch August 11, 2020 11:32
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@thisisobate
Chore: fix blog page layout to always contain contents (kedacore#793)
cb223fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zroubalik @tomkerkhove