Skip to content

Commit

Permalink
Update podinfo use-case + helm chart pipeline (merge commit drops the…
Browse files Browse the repository at this point in the history
… commit msg of the previous commit)

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
  • Loading branch information
jkremser committed Oct 23, 2024
1 parent 326c126 commit ee51d97
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release-chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
run: echo "noop, because of 'The workflow must contain at least one job with no dependencies'"
test:
runs-on: ubuntu-latest
if: startsWith(github.event.head_commit.message, '[post-release]')
if: startsWith(github.event.head_commit.message, '[post-release]') || contains(github.event.head_commit.message, 'kedify/chart-yaml-update')
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
publish:
runs-on: ubuntu-latest
if: startsWith(github.event.head_commit.message, '[post-release]')
if: startsWith(github.event.head_commit.message, '[post-release]') || contains(github.event.head_commit.message, 'kedify/chart-yaml-update')
needs: [test]
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ helm upgrade -i keda kedacore/keda --namespace keda --create-namespace
```bash
helm repo add kedify-otel https://kedify.github.io/otel-add-on/
helm repo update
helm upgrade -i keda-otel kedify-otel/otel-add-on --version=v0.0.0-1
helm upgrade -i keda-otel kedify-otel/otel-add-on --version=v0.0.1-0
```

### Create an example scaled object
Expand Down
16 changes: 14 additions & 2 deletions examples/metric-pull/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,23 @@ helm repo add kedify-otel https://kedify.github.io/otel-add-on
helm repo update
```

Any Kubernetes cluster will do:
```bash
k3d cluster create metric-pull -p "8181:31198@server:0"
```

Install demo webapp:

```bash
helm upgrade -i podinfo podinfo/podinfo -f podinfo-values.yaml
kubectl -n default port-forward deploy/podinfo 8080:9898
# check if the app is running
open http://localhost:8181
open http://localhost:8181/metrics
```

Install this addon:
```bash
helm upgrade -i kedify-otel kedify-otel/otel-add-on --version=v0.0.0-1 -f collector-pull-values.yaml
helm upgrade -i kedify-otel kedify-otel/otel-add-on --version=v0.0.1-0 -f collector-pull-values.yaml
```

Note the following section in the helm chart values that configures the OTEL collector to scrape targets:
Expand Down Expand Up @@ -87,3 +94,8 @@ Observer how number of replicas of Podinfo deployment is reacting on the load.
```bash
watch kubectl get pods -A
```

Once finished, clean the cluster:
```bash
k3d cluster delete metric-pull
```
5 changes: 5 additions & 0 deletions examples/metric-pull/podinfo-values.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
# https://github.com/stefanprodan/podinfo/blob/master/charts/podinfo/values.yaml
ui:
message: "Hello OTEL+KEDA"
color: "#222222"
logo: "https://kedify.io/assets/images/logo.svg"

service:
type: "NodePort"
nodePort: 31198
annotations:
prometheus.io/scrape: "true"
prometheus.io/path: "/metrics"
prometheus.io/port: "9898"
#ingress:
# enabled: true

0 comments on commit ee51d97

Please sign in to comment.