Skip to content

Commit

Permalink
revert(datasets): use pathlib, ignore Windows test
Browse files Browse the repository at this point in the history
Refs: b7ff0c7

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
  • Loading branch information
deepyaman committed Sep 24, 2024
1 parent b7ff0c7 commit c8f076e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 1 addition & 2 deletions kedro-datasets/kedro_datasets/ibis/file_dataset.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Provide file loading and saving functionality for Ibis's backends."""
from __future__ import annotations

import os
from copy import deepcopy
from pathlib import Path, PurePosixPath
from typing import TYPE_CHECKING, Any, ClassVar
Expand Down Expand Up @@ -119,7 +118,7 @@ def __init__( # noqa: PLR0913
super().__init__(
filepath=PurePosixPath(filepath),
version=version,
exists_function=os.path.exists,
exists_function=lambda filepath: Path(filepath).exists(),
)

# Set load and save arguments, overwriting defaults if provided.
Expand Down
2 changes: 2 additions & 0 deletions kedro-datasets/tests/ibis/test_file_dataset.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import sys
from pathlib import Path
from time import sleep

Expand Down Expand Up @@ -251,6 +252,7 @@ def test_save_version_warning(
with pytest.warns(UserWarning, match=pattern):
versioned_file_dataset.save(dummy_table)

@pytest.mark.skipif(sys.platform == "win32", reason="different error on windows")
def test_versioning_existing_dataset(
self, file_dataset, versioned_file_dataset, dummy_table
):
Expand Down

0 comments on commit c8f076e

Please sign in to comment.