You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way masking works in telemetry is, it imports KedroCLI from the kedro package. kedro-telemetry uses that to build a vocabulary of sorts. So when it receives a command that triggered this hook -> ['run', '--pipeline', 'pipe1'], it goes through the list and masks things that are not in the dictionary eg. ['run', '--pipeline', '*****'].
So if it receives ['run', '--pipeline', 'airflow'], this is not masked properly because "airflow" is a valid kedro command (kedro airflow create with the kedro-airflow plugin) and the word "airflow" is not masked.
Possible Implementation
Ideally, stop relying on the imported KedroCLI to do the masking. This will be one step closer to the general goal of revamping the kedro-telemetry workflow.
Possible Alternatives
(Optional) Describe any alternative solutions or features you've considered.
The text was updated successfully, but these errors were encountered:
Description
Some CLI commands are not masked properly before sending to Heap.
This is not a bug that users will encounter very often but would be good to fix!
Context
For complete context read - kedro-org/kedro#2522 (comment)
The way masking works in telemetry is, it imports
KedroCLI
from thekedro
package.kedro-telemetry
uses that to build a vocabulary of sorts. So when it receives a command that triggered this hook ->['run', '--pipeline', 'pipe1']
, it goes through the list and masks things that are not in the dictionary eg.['run', '--pipeline', '*****']
.So if it receives
['run', '--pipeline', 'airflow']
, this is not masked properly because "airflow" is a valid kedro command (kedro airflow create
with the kedro-airflow plugin) and the word "airflow" is not masked.Possible Implementation
Ideally, stop relying on the imported
KedroCLI
to do the masking. This will be one step closer to the general goal of revamping thekedro-telemetry
workflow.Possible Alternatives
(Optional) Describe any alternative solutions or features you've considered.
The text was updated successfully, but these errors were encountered: