Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: Fix masking of CLI commands #371

Closed
ankatiyar opened this issue Oct 5, 2023 · 2 comments · Fixed by #552
Closed

telemetry: Fix masking of CLI commands #371

ankatiyar opened this issue Oct 5, 2023 · 2 comments · Fixed by #552
Assignees
Labels
bug Something isn't working Hacktoberfest

Comments

@ankatiyar
Copy link
Contributor

ankatiyar commented Oct 5, 2023

Description

Some CLI commands are not masked properly before sending to Heap.
This is not a bug that users will encounter very often but would be good to fix!

Context

For complete context read - kedro-org/kedro#2522 (comment)

The way masking works in telemetry is, it imports KedroCLI from the kedro package.
kedro-telemetry uses that to build a vocabulary of sorts. So when it receives a command that triggered this hook -> ['run', '--pipeline', 'pipe1'], it goes through the list and masks things that are not in the dictionary eg. ['run', '--pipeline', '*****'].
So if it receives ['run', '--pipeline', 'airflow'], this is not masked properly because "airflow" is a valid kedro command (kedro airflow create with the kedro-airflow plugin) and the word "airflow" is not masked.

Possible Implementation

Ideally, stop relying on the imported KedroCLI to do the masking. This will be one step closer to the general goal of revamping the kedro-telemetry workflow.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.

@McDonnellJoseph
Copy link
Contributor

Hello is someone already working on this ?

@ankatiyar
Copy link
Contributor Author

@McDonnellJoseph Not yet, feel free to open a PR for this!

@merelcht merelcht moved this to To Do in Kedro Framework Feb 5, 2024
@DimedS DimedS moved this from To Do to In Progress in Kedro Framework Feb 7, 2024
@DimedS DimedS linked a pull request Feb 9, 2024 that will close this issue
4 tasks
@DimedS DimedS moved this from In Progress to In Review in Kedro Framework Feb 9, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants