[FIX] Mask all arguments if last argument was a parameter #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @McDonnellJoseph , would you like to continue working on this PR or do you need some help completing it? |
|
This was fixed in #552, thanks @McDonnellJoseph ! Hope you can contribute at some other time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a proposal PR to fix issue #371.
Development notes
A temporary solution is to mask any arguments following a parameter indifferently of if this argument is present in the vocabulary.
However this still relies on Kedro CLI for the masking I'll look further into this to propose a solution without Kedro CLI.
Checklist
RELEASE.mdfile