test(datasets): update the "no versioning" message #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @deepyaman! Regarding the PR kedro-org/kedro#267 do you think its close to completion? if its close it might be worth waiting for that one first. What are the major changes in that PR and how do they impact the current one? |
noklam
approved these changes
Jun 20, 2023
|
From what I understood, kedro-org/kedro#2673 is ready for review, and must be merged first |
astrojuanlu
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In réponse to kedro-org/kedro#2500 changing the error message, any tests that specifically check that message need to be updated accordingly.
Note that this will no pass until kedro-org/kedro#2673 is merged. #239 showcases a passing build (hardcoded to build using the
refactor/rename-data-setsbranch of #2673).Development notes
Checklist
RELEASE.mdfile