Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasets): Add NetCDFDataSet class #360
feat(datasets): Add NetCDFDataSet class #360
Changes from 49 commits
cfd040c
fa8f922
b3ec640
3d1b1f3
37ba9c2
0ccd58a
de0b044
532fad8
526a0ce
84df521
7bcef79
4dce2a5
c9b320b
b67aabc
0f018fe
0bff0fb
b776e9e
9bb8063
99d80fd
004203a
755ec17
037846d
76b32e6
283002b
50b84e9
f6b1168
5ea49f1
9cd98b7
5468c65
6f93d70
b68bf41
0aa1965
1d65b81
4369f03
dfbf94f
249deb7
df83360
ff2e0c2
d17fa53
bf2235e
b09d927
9ff704a
7437e5d
de0f135
0e93a62
fb898d5
32be659
1cb07f8
ed5ca39
7130d2c
50e093c
380ca34
35f9b11
feb37b7
51feeab
411a057
8588573
b6ae60b
83e523c
a2caff8
25c7c5c
f838783
195be05
120a757
fc57ba2
16f906f
210e4ed
88a63ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with AWS and GCS, but not sure if this is generalized enough.
get_filepath_str
consistently drops the prefix of URI's from object storage, which is problematic for the subsequentfs.get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah filepath mangling in fsspec is tricky... we have a related open issue about this kedro-org/kedro#3196