Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Debug bump s3fs #459

Closed
wants to merge 19 commits into from
Closed

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Dec 1, 2023

Description

Attempt to solve issues with tests in:

The problem that surfaced in #348 is described here: aio-libs/aiobotocore#755 Lots of people have provided patches, so I have used one of the most up to date ones and it seems to work almost perfectly.

Development notes

Tests that are still broken and have been commented out for the time being:

  • tests/dask/test_parquet_dataset.py test_pass_credentials
  • tests/spark/test_spark_dataset.py test_no_version

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht requested a review from noklam December 4, 2023 11:23
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. We either need to mock the response or use "moto server" ( see s3fs tests]. Since this is just unit tests problem (s3fs works regardless of versions, the problem is the interaction with moto), I am happy to proceed with this.

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht mentioned this pull request Dec 5, 2023
4 tasks
@merelcht
Copy link
Member Author

merelcht commented Dec 5, 2023

Closing in favour of #463

@merelcht merelcht closed this Dec 5, 2023
@merelcht merelcht deleted the experiment-moto-stuff-from-main branch December 11, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants