Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(kedro-airflow): grouping with fork #536

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sbrugman
Copy link
Contributor

@sbrugman sbrugman commented Feb 2, 2024

Description

Fixes a bug in the grouping when multiple groups need to be merged.

Development notes

Discovered after running on new DAGs.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Simon Brugman <sbrugman@users.noreply.github.com>
@sbrugman sbrugman marked this pull request as ready for review February 2, 2024 17:02
@astrojuanlu
Copy link
Member

Tests still failing:

FAILED tests/test_node_grouping.py::test_group_memory_nodes[memory_nodes0-expected_nodes0-expected_dependencies0] - AttributeError: 'NoneType' object has no attribute 'append'

@sbrugman sbrugman marked this pull request as draft February 3, 2024 10:22
@ankatiyar ankatiyar added the Community Issue/PR opened by the open-source community label Feb 13, 2024
@merelcht
Copy link
Member

Hi @sbrugman, do you want to continue working on this PR?

@sbrugman
Copy link
Contributor Author

Yes, I'll rebase and fix the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants