Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): Trying to fix e2e tests #548

Merged
merged 16 commits into from
Feb 12, 2024
4 changes: 2 additions & 2 deletions kedro-docker/features/docker.feature
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ Feature: Docker commands in new projects
Scenario: Execute docker jupyter notebook target
Given I have executed the kedro command "docker build"
When I execute the kedro command "docker jupyter notebook"
Then Jupyter Notebook should run on port 8888
Then Jupyter Server should run on port 8888

Scenario: Execute docker jupyter notebook target on custom port
Given I have executed the kedro command "docker build"
When I execute the kedro command "docker jupyter notebook --port 8899"
Then Jupyter Notebook should run on port 8899
Then Jupyter Server should run on port 8899

Scenario: Execute docker jupyter lab target
Given I have executed the kedro command "docker build"
Expand Down
2 changes: 1 addition & 1 deletion kedro-docker/features/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def before_all(context):
# Temporarily pin pip to fix https://github.com/jazzband/pip-tools/issues/1503
# This can be removed when Kedro 0.17.6 is released, because pip-tools is upgraded
# for that version.
"pip>=20.0,<21.3",
"pip>=21.2,<23.2",
"setuptools>=38.0",
"wheel",
".",
Expand Down
3 changes: 2 additions & 1 deletion kedro-docker/kedro_docker/template/Dockerfile.simple
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ FROM $BASE_IMAGE as runtime-environment

# install project requirements
COPY requirements.txt /tmp/requirements.txt
RUN pip install --no-cache -r /tmp/requirements.txt && rm -f /tmp/requirements.txt
RUN python -m pip install -U "pip>=21.2,<23.2"
RUN pip install --no-cache-dir -r /tmp/requirements.txt && rm -f /tmp/requirements.txt

# add kedro user
ARG KEDRO_UID=999
Expand Down
3 changes: 2 additions & 1 deletion kedro-docker/kedro_docker/template/Dockerfile.spark
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ apt-get install -y procps default-jre-headless && rm -rf /var/lib/apt/lists/*

# install project requirements
COPY requirements.txt /tmp/requirements.txt
RUN pip install --no-cache -r /tmp/requirements.txt && rm -f /tmp/requirements.txt
RUN python -m pip install -U "pip>=21.2,<23.2"
RUN pip install --no-cache-dir -r /tmp/requirements.txt && rm -f /tmp/requirements.txt

# add kedro user
ARG KEDRO_UID=999
Expand Down
Loading