Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(datasets): Normalise optional requirements names and move them to pyproject.toml #570

Merged
merged 6 commits into from
Feb 29, 2024
Merged

chore(datasets): Normalise optional requirements names and move them to pyproject.toml #570

merged 6 commits into from
Feb 29, 2024

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Feb 26, 2024 •
edited
Loading

Description

Proposal for #313

Development notes

  • Nomalised all optional requirements in accordance with PEP 685
  • Move all requirements to pyproject.toml
  • Remove setup.py

If we're happy with the naming already - we can merge this and release kedro-datasets 3.0.0
Follow up actions required -

  • Release kedro-datasets
  • Update docs on Kedro
  • Update requirements.txt in kedro-starters
  • Unpin pip in most places that we've pinned it in

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@ankatiyar
Normalise and move extras dependencies to pyproject.toml
cbbba90 
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
astrojuanlu
astrojuanlu approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 on basically turning all the extras groups to lowercase and replace . by - 💯

We'd need to update our docs, starters etc but at least I agree with this solution

@ankatiyar ankatiyar requested review from noklam and merelcht February 26, 2024 16:42
@lrcouto
Copy link
Contributor

lrcouto commented Feb 26, 2024

I'm +1 on basically turning all the extras groups to lowercase and replace . by - 💯

We'd need to update our docs, starters etc but at least I agree with this solution

I agree. It's a pretty straightforward solution. It'd need the aforementioned housecleaning on docs, starters, etc. but I like it.

@ankatiyar
Update kedro-datasets/pyproject.toml
ecb4d23 
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
@ankatiyar ankatiyar marked this pull request as ready for review February 26, 2024 16:58
@astrojuanlu
Copy link
Member

We decided to hold this until kedro-datasets 2.1.0 is released 👍🏽

@ankatiyar ankatiyar changed the title chore(datasets): Normalise optional requirements names and move them to pyproject.toml chore(datasets): [not to be merged yet!] Normalise optional requirements names and move them to pyproject.toml Feb 26, 2024
@ankatiyar
Copy link
Contributor Author

ankatiyar commented Feb 27, 2024 •
edited
Loading

Reminder to do another pass at setup.py before merging to make sure all versions are up to date - #537

@lrcouto lrcouto mentioned this pull request Feb 29, 2024
Merged
3 tasks
@ankatiyar
Merge main into branch
d940107 
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar
Update pyproject and release notes
893ab66 
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar
Update pyproject and release notes
3c078ec 
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar ankatiyar changed the title chore(datasets): [not to be merged yet!] Normalise optional requirements names and move them to pyproject.toml chore(datasets): Normalise optional requirements names and move them to pyproject.toml Feb 29, 2024
@ankatiyar ankatiyar enabled auto-merge (squash) February 29, 2024 15:48
@ankatiyar ankatiyar merged commit 6828ee7 into main Feb 29, 2024
13 checks passed
@ankatiyar ankatiyar deleted the ankita/extras-dependencies branch February 29, 2024 16:16
@astrojuanlu astrojuanlu mentioned this pull request Feb 29, 2024
Closed
@lrcouto lrcouto mentioned this pull request Mar 1, 2024
Merged
7 tasks
This was referenced Mar 2, 2024
Closed
Merged
jerome-asselin-buspatrol pushed a commit to jerome-asselin-buspatrol/kedro-plugins that referenced this pull request Mar 11, 2024
@ankatiyar @lrcouto @jerome-asselin-buspatrol
chore(datasets): Normalise optional requirements names and move them …
57c6a75 
…to `pyproject.toml` (kedro-org#570)

* Normalise and move extras dependencies to pyproject.toml

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Update kedro-datasets/pyproject.toml

Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>

* Update pyproject and release notes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Update pyproject and release notes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

---------

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Signed-off-by: Jerome Asselin <jerome.asselin@buspatrol.com>
tgoelles pushed a commit to tgoelles/kedro-plugins that referenced this pull request Jun 6, 2024
@ankatiyar @lrcouto @tgoelles
chore(datasets): Normalise optional requirements names and move them …
b1f16c9 
…to `pyproject.toml` (kedro-org#570)

* Normalise and move extras dependencies to pyproject.toml

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Update kedro-datasets/pyproject.toml

Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>

* Update pyproject and release notes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Update pyproject and release notes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

---------

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@noklam noklam noklam approved these changes

@lrcouto lrcouto lrcouto approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@merelcht merelcht Awaiting requested review from merelcht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ankatiyar @lrcouto @astrojuanlu @noklam @SajidAlamQB