Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasets): Use lazy .sink_* instead of collecting data #619

Closed
wants to merge 1 commit into from
Closed

fix(datasets): Use lazy .sink_* instead of collecting data #619

wants to merge 1 commit into from

Conversation

astrojuanlu
Copy link
Member

Fix #519.

cc @cpinon-grd @butterlyn could you give this a try?

Description

Development notes

This doesn't yet have a regression test nor an entry in the release notes.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@astrojuanlu
Use lazy sink instead of collecting data
f8893b6 
Fix #519.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@merelcht merelcht mentioned this pull request Aug 19, 2024
Closed
16 tasks
@astrojuanlu
Copy link
Member Author

Since sink_* methods are still marked as experimental and we will likely see changes very soon (Polars 2.0?) let's close this for now.

@astrojuanlu astrojuanlu deleted the fix/polars-lazy-scan branch August 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polars.LazyPolarsdataset .collect() streaming
1 participant
@astrojuanlu