feat(datasets): Added PyTorchDataset #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bpmeek, could you resolve the DCO failures following the instructions here - https://github.com/kedro-org/kedro-plugins/pull/735/checks?check_run_id=26337551853 |
bpmeek
force-pushed
the
feature/pytorch-dataset
branch
2 times, most recently
from
bbbd8df
to
2b7a162
Compare
Signed-off-by: bpmeek <bpmeek.developer@gmail.com>
Signed-off-by: bpmeek <bpmeek.developer@gmail.com>
bpmeek
force-pushed
the
feature/pytorch-dataset
branch
from
2b7a162
to
c729731
Compare
|
I'm not sure what to do about the unit-test failures, none of them are related to my changes. running |
|
@bpmeek Yeah the failures don't seem to be related, I'll take a look at the CI failures! Thanks for fixing the DCO check! |
16 tasks
Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
DimedS
approved these changes
Aug 21, 2024
merelcht
added a commit
to galenseilis/kedro-plugins
that referenced
this pull request
Aug 27, 2024
* Added PyTorchDataset Signed-off-by: bpmeek <bpmeek.developer@gmail.com> * updated RELEASE.md Signed-off-by: bpmeek <bpmeek.developer@gmail.com> * Add dependencies for PyTorchDataset Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> * Add PyTorchDataset to API docs Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> * Fix docs build Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> --------- Signed-off-by: bpmeek <bpmeek.developer@gmail.com> Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Co-authored-by: Merel Theisen <merel.theisen@quantumblack.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes 714
Development notes
Added PyTorchDataset to use pytorch's recommended save and load methods. Added tests to
kedro-datasets/tests/kedro_datasets_experimental/pytorch/test_pytorch_dataset.pyChecklist
RELEASE.mdfile