fix(datasets): Unpin pandas gbq #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Monroy <felipe.m02@gmail.com>
felipemonroy
force-pushed
the
fix-unpin-pandas-gbq
branch
from
949627c
to
4c593d6
Compare
|
@ankatiyar @astrojuanlu @noklam could you help me re-running the tests please? |
|
@felipemonroy Are you able to reproduce the test failures locally? |
|
@astrojuanlu I can't. I assume it is related to this issue #755. Right now, passing the tests requires a bit of luck. |
|
@astrojuanlu could you review again please? |
noklam
approved these changes
Aug 19, 2024
16 tasks
|
Can't believe we managed to merge this finally 😅 thanks for your patience @felipemonroy ! |
merelcht
pushed a commit
to galenseilis/kedro-plugins
that referenced
this pull request
Aug 27, 2024
Signed-off-by: Felipe Monroy <felipe.m02@gmail.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More recent versions of pandas does not work with
pandas-gbq<0.18.0, which was set forpython < 3.11Development notes
Checklist
RELEASE.mdfile